Conversation
ericglau
left a comment
There was a problem hiding this comment.
LGTM in terms of the Wizard code, thanks!
I did not fully review the generated output though, it would be good if someone else can review those.
|
Hey @ericglau I reviewed the output, refactored the hooks a bit, and compiled locally. Why can't I see the deploy preview though, does every commit need to be approved?. Note that is harder to review without it even for myself. |
|
Btw it took me 66 minutes to compile 😢 |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/ethereum-cryptography@3.0.0 |
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is a CVE?Contains a high severity Common Vulnerability and Exposure (CVE). Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
The @SocketSecurity ignore npm/rollup@2.79.2 |
This PR proposes to move the votes logic to common-components. This PR also proposes to include votes functionality for erc721.
I ran
yarn run update_scarb_projecton the test project and compiled...after 24 short minutes, there are no errors or warnings :)