Add linter (and formatter through eslint), config and ci action step#452
Merged
CoveMB merged 18 commits intoOpenZeppelin:masterfrom Feb 24, 2025
Merged
Add linter (and formatter through eslint), config and ci action step#452CoveMB merged 18 commits intoOpenZeppelin:masterfrom
CoveMB merged 18 commits intoOpenZeppelin:masterfrom
Conversation
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Member
|
@SocketSecurity ignore npm/ws@7.4.6 |
Member
|
@SocketSecurity ignore npm/undici@5.28.4 Unrelated to this PR, see #430 (comment) |
Co-authored-by: Eric Lau <ericglau@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add eslint and required packages.
Add recommended eslint configuration (including prettier and unicorn) for various files type (similarly to what is found in openzeppelin-upgrades).
Make changes so that the current codebase complies with added lint rules.
Add lint step in CI action.
Run linter with --fix to adjust prettier rules.
Fixes #429
Fixes #446