Use onlyGovernance to restrict upgrades for Governor with UUPS#544
Merged
CoveMB merged 4 commits intoOpenZeppelin:masterfrom May 21, 2025
Merged
Use onlyGovernance to restrict upgrades for Governor with UUPS#544CoveMB merged 4 commits intoOpenZeppelin:masterfrom
onlyGovernance to restrict upgrades for Governor with UUPS#544CoveMB merged 4 commits intoOpenZeppelin:masterfrom
Conversation
Contributor
Author
|
@ericglau I was having some conflict in the previous PR so I had to close it. Here is a new PR where the master branch is up to date. Please review and let me know if I need to change anything. |
ericglau
requested changes
May 12, 2025
Member
There was a problem hiding this comment.
- I've added a comment where a refactor would be useful.
- Please add a changeset according to steps in https://github.com/OpenZeppelin/contracts-wizard/blob/master/CONTRIBUTING.md#adding-changesets
…mon logic into helper functions for improved code clarity and maintainability.
Contributor
Author
|
@ericglau Could you kindly check if everything is alright now? |
onlyGovernance to restrict upgrades for Governor with UUPS
ericglau
approved these changes
May 14, 2025
Member
ericglau
left a comment
There was a problem hiding this comment.
Thanks for the updates. I pushed some refactors and fixed the tests. We'll do some additional reviews before merging.
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #144 by modifying the Governor contract to utilize the onlyGovernance modifier for the _authorizeUpgrade function when the contract is set as UUPS upgradeable.
Changes Made:
Fixes #144