Cairo add security contract field#558
Merged
CoveMB merged 45 commits intoOpenZeppelin:masterfrom Jun 20, 2025
Merged
Conversation
Co-authored-by: Eric Lau <ericglau@outlook.com>
ericglau
approved these changes
May 26, 2025
Member
ericglau
left a comment
ericglau
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Note this should also be added to cairo_alpha (could be in this PR or a separate PR)
ericglau
reviewed
Jun 6, 2025
ericglau
reviewed
Jun 6, 2025
ericglau
approved these changes
Jun 6, 2025
ericnordelo
reviewed
Jun 13, 2025
Member
ericnordelo
left a comment
ericnordelo
left a comment
There was a problem hiding this comment.
Hey, the changes look good to me. I wonder if we should use this NatSpec format keeping in mind that we don't follow that standard for comments in Starknet. Maybe something like the following is enough?
/// Security contact: security@example.com
Contributor
Author
|
@ericnordelo thanks for the guidance, made the changes just double checking, using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #440 (for Cairo and Cairo-alpha only)