Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces stablecoin support by adding a new Stablecoin tab, refactors access control to support both Ownable and Roles, and updates the default versions along with a macro-based implementation for fungible and non‐fungible token contracts.
- Adds a new Stablecoin module with allow-/blocklist limitations
- Updates access control logic across contracts to include roles support
- Refactors the contract function definition to leverage the default_impl macro
Reviewed Changes
Copilot reviewed 20 out of 33 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ui/src/stellar/AccessControlSection.svelte | Implements UI for access control with reactive updates |
| packages/core/stellar/src/utils/version.ts | Updates version constants to 0.3.0-rc.2 |
| packages/core/stellar/src/utils/define-functions.ts | Refactors function definitions to remove implicit name handling |
| packages/core/stellar/src/stablecoin.ts | Adds new stablecoin logic and limitations handling |
| packages/core/stellar/src/set-access-control.ts | Expands access options to include roles and adjusts access enforcement logic |
| Others (tests, API, generators, etc.) | Updates to support stablecoin inclusion and access control consistency |
Comments suppressed due to low confidence (1)
packages/core/stellar/src/stablecoin.ts:57
- [nitpick] Using 'type' as a variable name can be confusing due to its overlap with the TypeScript keyword; consider renaming it to 'isAllowlist' or a similar descriptive name to improve code clarity.
const type = mode === 'allowlist';
ericglau
requested changes
Jun 23, 2025
ozgunozerk
reviewed
Jun 24, 2025
ozgunozerk
reviewed
Jun 24, 2025
Contributor
ozgunozerk
left a comment
There was a problem hiding this comment.
Looking great in general, big chunk of work, thanks 💯
After the comments have resolved, should be good to go. Will test the webapp in the meantime and will let you know if I find any bug 👍
ozgunozerk
approved these changes
Jun 24, 2025
Co-authored-by: Eric Lau <ericglau@outlook.com>
ericglau
approved these changes
Jun 25, 2025
Member
ericglau
left a comment
There was a problem hiding this comment.
LGTM, thanks for the great work!
ericglau
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default_implmacroTodo: