[Stellar] Add rust ci compilation#594
Merged
CoveMB merged 90 commits intoOpenZeppelin:masterfrom Jul 31, 2025
Merged
Conversation
Co-authored-by: Eric Lau <ericglau@outlook.com>
…-wizard into add-rust-ci-compilation
Contributor
Author
|
@brozorec @ozgunozerk I removed the warning and all current compilations test goes through (after resolving this) |
ericglau
reviewed
Jul 25, 2025
| }, | ||
| ); | ||
|
|
||
| test('placeholder', t => t.assert(true)); |
Member
There was a problem hiding this comment.
When will this placeholder be replaced with the actual tests?
Contributor
Author
There was a problem hiding this comment.
I thought of reviewing those tests while working on the scaffold zip backend
.github/workflows/test.yml
Outdated
| # id: get-scaffold-sha | ||
| # run: | | ||
| # echo "sha=$(git ls-remote https://github.com/ahalabs/scaffold-stellar HEAD | cut -f1)" >> $GITHUB_OUTPUT | ||
| echo "sha=ebf79b8a57ad1b51a46162afd98ca05c648085fe" >> $GITHUB_OUTPUT |
Member
There was a problem hiding this comment.
How will this SHA be updated going forward?
…-wizard into add-rust-ci-compilation
Contributor
Author
|
@ozgunozerk Sorry I missed your question, exactly in the TS compilation tests we run cargo related commands to compile the different options of contracts |
ericglau
reviewed
Jul 29, 2025
ericglau
approved these changes
Jul 30, 2025
brozorec
approved these changes
Jul 31, 2025
| @@ -0,0 +1,71 @@ | |||
| import { tmpdir } from 'os'; | |||
| import type { ExecutionContext } from 'ava'; | |||
| import _test from 'ava'; | |||
Contributor
There was a problem hiding this comment.
Is this import needed given we have import test from 'ava'; below? Both imports are present in a couple of the files.
…-wizard into add-rust-ci-compilation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add compilation tests
Description