Skip to content

Update Wizard's get API key link#52

Merged
ericglau merged 1 commit intoOpenZeppelin:mainfrom
ericglau:wizardapikeylabel
Mar 19, 2025
Merged

Update Wizard's get API key link#52
ericglau merged 1 commit intoOpenZeppelin:mainfrom
ericglau:wizardapikeylabel

Conversation

@ericglau
Copy link
Member

@ericglau ericglau commented Mar 17, 2025

Changes the Wizard deploy plugin's "Get API Key" link to specifically mention OpenZeppelin Defender, and moved it above "API Key" label to avoid having too much text in one line.

(This allows us to change the "Deploy with Defender" label in Wizard to simply "Deploy", and have the context about OpenZeppelin Defender within this plugin.)

Screenshot 2025-03-17 at 8 00 23 PM

@ericglau ericglau requested a review from CoveMB March 17, 2025 21:32
@netlify
Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for effervescent-moonbeam-f3627f ready!

Name Link
🔨 Latest commit 46d38fb
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-moonbeam-f3627f/deploys/67daddcbacce260007623106
😎 Deploy Preview https://deploy-preview-52--effervescent-moonbeam-f3627f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@CoveMB CoveMB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great, more clear, I wonder if we could even maybe add a little sentence or 2 bellow in smaller font to conextualize what Defender is (redirecting to deploy doc maybe)

@ericglau
Copy link
Member Author

That looks great, more clear, I wonder if we could even maybe add a little sentence or 2 bellow in smaller font to conextualize what Defender is (redirecting to deploy doc maybe)

We can consider that in a follow-up PR.

@ericglau ericglau force-pushed the wizardapikeylabel branch from 091318e to 46d38fb Compare March 19, 2025 15:07
@ericglau ericglau merged commit c12d766 into OpenZeppelin:main Mar 19, 2025
3 of 4 checks passed
@ericglau ericglau deleted the wizardapikeylabel branch March 19, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants