Conversation
- Add new ChartPanel component - Implement dual-panel layout supporting both text and chart views - Add panel visibility controls with mutual exclusion logic - Extend AppSettings with show_chart_panel and show_text_panel flags - Update menu bar with panel toggle checkboxes that prevent disabling both panels - Add chart panel settings to settings panel - Implement dynamic space allocation when both panels are visible - Export ChartPanel in gui module for app-wide access
- Add CSV data parsing with stream buffering to handle fragmented serial data - Implement auto-scaling chart display based on actual data ranges - Add samples storage using VecDeque<f32> with 1000-sample limit - Integrate chart data processing into main app serial event handling - Replace animated sine waves with real-time data visualization - Add horizontal grid lines for better data readability - Implement robust parsing that handles incomplete CSV streams - Add buffer management to prevent memory growth from partial data The chart panel now parses comma-separated numeric values from serial data and displays them as a line chart with automatic Y-axis scaling and padding. Data processing only occurs when chart panel is visible for performance. Stream buffer handles fragmented data across multiple serial packets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the first implementation of graph mode for SerialGUI-rs, allowing users to visualize serial data as a chart.
Key Changes
ChartPanel Added
ChartPanelstruct for rendering real-time data as a graph.src/gui/chart_panel.rs.Settings Integration
show_chart_panelandshow_text_paneloptions toAppSettings.UI Updates
Module Organization
ChartPanelingui/mod.rs.Motivation
This feature provides users with a visual representation of incoming serial data, enhancing the application's usability for monitoring and analysis.
Note:
This is an initial implementation; further improvements and features may be added in future