Add coveralls to track code coverage #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
apex-omontgomery
left a comment
apex-omontgomery
left a comment
There was a problem hiding this comment.
Had to force a rebuild as it didn't automatically run after the merge of other PR.
Our coverage went from 15 percent to 66 percent, so yay.
When it finishes and tries to run coveralls I get an error:
0.86s$ coveralls
Submitting coverage to coveralls.io...
Coverage submitted!
Couldn't find a repository matching this job.
Traceback (most recent call last):
File "/home/travis/virtualenv/python3.7.1/bin/coveralls", line 11, in <module>
sys.exit(main())
File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/coveralls/cli.py", line 80, in main
log.info(result['url'])
KeyError: 'url'But it shows passing.
aaron-junot
force-pushed
the
add-coveralls
branch
from
59e9758 to
7fda55e
Compare
aaron-junot
force-pushed
the
add-coveralls
branch
from
7fda55e to
a0e0e56
Compare
Member
Author
|
Close in favor of #80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have some working tests via #70, we should also add code coverage via coveralls. Ideally, we'll be able to increase our code coverage to something very close to 100%, but we'll see once we get there. For now, let's just go ahead and get tracking on it.