measurementsets "disappering"

[enaisoc]

1. I created a set of measurements logged in with google.
2. I logged out from google
3. I created a set of measurements - the measurments from 1. disappeared
4. I logged in
5. the in 3. created set of measurement disappeared and the from 1. appeared again
   (same when I create the first set without login - nothing synced after a login)
   the measurements created offline should be synced, after a login

[paarandika]

Saved measurement list only shows the user's measurements. So when log out, measurements you created as "someone" will disappear because when you log out you are not that someone. When you create measurement without logging in they will have no user assigned. But when you log in app will assign those measurements to logged in user. So first part of this issue is expected behavior. But when you log in again those measurements you created while logged out should be assigned to you. So will look in to that correct it.

[joerx]

I'm not sure what to think about the part where anonymous records are assigned to a user when they log in - while I understand the reasoning (user uses app w/o log in, later they log in and 'claim' the records they created earlier) the whole thing seems rather confusing to me.

We may want to make this a lot simpler by simply not allowing the app to be used 'anonymously'. User has to log in at all times. By now, we only support Google Accounts, but that might be changed soon, so a simple "email/password" login would also work.

When "logging" out, the user would effectively disconnect their account from the app, so for privacy reasons all data left on device would need to be purged, including measurementsets. I'm don't think we even need to provide an option inside the app, since that can be achieved via Android's system settings.

[paarandika]

I first created the app in a way where you have to log in to create measurements. But I was told to make it fully offline capable. So this is the solution I came up with. I couldn't think of any other way to facilitate both online and offline features. But if we assume that a phone is a personnel device this thing wont be a huge issue. I can make the log in a must if you want. But again that will destroy the offline capability.
And as we are on still on Android only, I think log in with Google is enough because every android user has a Google account.

[joerx]

The idea behind offline was more to be able to still use the app while temporary offline, e.g. when I'm taking measurements (which can be a long-running process where I have to move around a lot) the app should not fail or lose data because the Wifi disconnects.

If the user needs to be online to sign into the app first time that's reasonable I think, even though I still think there must be a way to do even that offline when using an Android-phone. After all, the users ID is basically tied to the phone already, no? Anyway, as I said, even needing to be online for initial setup is still good enough as long as they can use the App offline once it's linked to their account.

[paarandika]

Then shall I add the the functionality to make initial sign in a must? And we can get user's email from phone. But not his name and password. Getting email that way is kind of frowned upon.

[joerx]

OK, just ask for sign up on first start and we will not try to get the
email from the phone.
On Aug 3, 2014 4:04 PM, "Ayantha Randika" notifications@github.com wrote:

Then shall I add the the functionality to make initial sign in a must? And
we can get user's email from phone. But not his name and password. Getting
email that way is kind of frowned upon.

—
Reply to this email directly or view it on GitHub
#17 (comment)
.

[paarandika]

I disabled create and saved buttons if user is not signed in and alert him to sign in. Please check branch issue_17.

[paarandika]

Is branch issue_17 working fine? Can I create a PR for that?

[joerx]

Please create PRs whenever you feel you are ready. We will review and merge them if we consider it done. If there is more work and stuff get's pushed to the branch, it will show up in the PR automatically.