update wasm related crates#32
Merged
BrytonLee merged 2 commits intoOptimatistOpenSource:mainfrom Jun 3, 2024
serephus:update_incompatible_dependencies
Merged
update wasm related crates#32BrytonLee merged 2 commits intoOptimatistOpenSource:mainfrom serephus:update_incompatible_dependencies
BrytonLee merged 2 commits intoOptimatistOpenSource:mainfrom
serephus:update_incompatible_dependencies
Conversation
BrytonLee
requested changes
Jun 3, 2024
Member
BrytonLee
left a comment
BrytonLee
left a comment
There was a problem hiding this comment.
I would like to see the upgradation of each dependency to be a separate PR. Please do that if you're also agree.
Contributor
Author
done |
BrytonLee
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasmtime and it's related crates have published 3 major releases in 3 months, there are some drastic changes in these releases, maybe we should update ASAP?
I've update some of usage of this changed APIs, but it require more changes to do things right. I plan to submit more PRs to adapt wasm related crates updates.
TODO: