Crappy software #18
Description
No. This is fucking garbage and it came in too late. I asked for early submissions because I’m traveling, and if you can’t follow that simple fucking rule, at least make the installer good.
Instead, this dumps random crap that isn’t installer-specific into generic utility code.
And by “garbage” I mean actual fucking garbage. This is the kind of shit nobody should ever submit, never mind at the last fucking minute.
Like this absolute clown-shoe of a function:
def apply_patch_and_install(patch_file, package_file):
# mysterious bullshit happens here
...
This thing makes the installer actively a worse place to exist. It’s useless crap that makes the flow incomprehensible, and actively WORSE than just writing the code inline.
If you just wrote:
if patch_file.exists():
apply_patch(patch_file)
install_package(package_file)
everyone immediately knows what it does. Maybe not the sexiest code ever, but at least it’s obvious and not wrong.
In contrast, your magical black-box apply_patch_and_install() gives zero fucking clue what’s going on. Then you were genius enough to shove this shit into utils.py so it can pollute everything else too. That’s not simplifying, that’s just hiding logic and making debugging a goddamn nightmare.
So no. This kind of crap needs to get bent. It doesn’t belong in generic utilities, and it sure as hell does not get merged hours before a release.
L