[FIX] Food & Fluid not organised by effective date#111
Merged
DaeronAlagos merged 1 commit intoremove-custom-frequencyfrom Jul 31, 2020
Merged
[FIX] Food & Fluid not organised by effective date#111DaeronAlagos merged 1 commit intoremove-custom-frequencyfrom
DaeronAlagos merged 1 commit intoremove-custom-frequencyfrom
Conversation
* F&F should be grouped by effective date to calculate for a 24 hour period * Some records not showing in chart * Display not sorted by effective date
PeterAlabaster
approved these changes
Jul 30, 2020
Contributor
PeterAlabaster
left a comment
PeterAlabaster
left a comment
There was a problem hiding this comment.
Approving but see comment, not sure if it's an issue or not.
| }); | ||
| for ( var idx = 0; idx < serverData.length; idx++ ) { | ||
| var data = serverData[idx]; | ||
| data.observations.sort( function (a, b) { |
Contributor
There was a problem hiding this comment.
Does this not require re-assigning (data.observations = data.observations.sort(....) ?
Contributor
Author
There was a problem hiding this comment.
Not this time. sort() changes inline rather than assigns to a new array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16631