Merged
Conversation
PeterAlabaster
approved these changes
Mar 13, 2018
| @http.route(URLS['all_patients'], type='http', auth="user") | ||
| def get_all_patients(self, *args, **kw): | ||
| """ | ||
| Returns the patient task list for patients. |
Contributor
There was a problem hiding this comment.
Returns the patient task list for all patients
Author
There was a problem hiding this comment.
Good spot. Updating now...
|
|
||
| cr, uid, context = request.cr, request.session.uid, request.context | ||
| patient_api = request.registry['nh.eobs.api'] | ||
| patient_api.unassign_my_activities(cr, uid) |
Contributor
There was a problem hiding this comment.
This seems unusual, why are activities unassigned, simply by listing 'All Patients' view?
I'm guessing it's what the other lists do
Author
There was a problem hiding this comment.
No idea, it's just a copy of the get_patients function with the uid removed from the domain.
Contributor
There was a problem hiding this comment.
OK, np. I think sticking to what it does now is the safest bet. Just seems a little unusual
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an additional column to the mobile view. The new column lists all patients, not just those assigned to the current user.