[IMP] More fields on the mobile view should be required#14
Merged
james-opusvl merged 1 commit intoprodfrom Mar 14, 2018
Merged
Conversation
PeterAlabaster
approved these changes
Mar 14, 2018
Contributor
PeterAlabaster
left a comment
PeterAlabaster
left a comment
There was a problem hiding this comment.
I take it the necessary parameter is some strange thing that comes from a bastardised version of Odoo fields which comes from obs_fields
Author
|
I'm saying yes to that. I didn't look to see where it derives from. I did find out the hard way that the db required isn't enough, and without the form validation too you get a 500 error. |
PeterAlabaster
pushed a commit
that referenced
this pull request
Mar 21, 2018
[IMP] More fields on the mobile view should be required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In follow up to the conference call, this PR changes the requirements of fields of the F&F submission form at the database level and for client side validation (mobile view)