Skip to content

fix(datastore): fail if too many results #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
lionelfleury wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix(datastore): fail if too many results #11

lionelfleury wants to merge 3 commits into from
+151 −66

Conversation

@lionelfleury
Copy link

@lionelfleury lionelfleury commented Dec 23, 2025

  • remove silent LIMIT & add count field in SQL queries
  • allow to fail fast if too many results (no need to iterate until MaxResultLimit constant)
  • add a test for ListExpiredSubscriptions

Fixes interuss#1120

@lionelfleury lionelfleury force-pushed the fix/fail-if-too-many branch 2 times, most recently from 8b21dd4 to 87f7dd9 Compare December 23, 2025 11:32
@lionelfleury
Copy link
Author

lionelfleury commented Dec 29, 2025

This is an alternative approach to #12.
It would allow to fail fast if too many results is a more common behavior (putting load on backend to compute result count).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[store] Result list is silently limited to 10000 items

1 participant

@lionelfleury