Skip to content

Fixed potential array overflow in alloc_recv_array #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidbowler merged 1 commit into from
Feb 10, 2026
Merged

Fixed potential array overflow in alloc_recv_array #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/UpdateInfo_module.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1300,6 +1300,8 @@ end subroutine CommMat_send_data
!! Changing MPI tag to conform to standard
!! 2019/11/14 tsuyoshi
!! Added InfoGlob in dummy arguments, and removed glob2node_old
!! 2026/02/10 10:45 dave
!! Bug fix: changed nreq to single integer (used in block receive)
!! SOURCE
!!
subroutine alloc_recv_array(InfoGlob,irecv_array,irecv2_array,recv_array, &
Expand Down Expand Up @@ -1334,7 +1336,7 @@ subroutine alloc_recv_array(InfoGlob,irecv_array,irecv2_array,recv_array, &
logical :: flag_find_old
! -- process 2. -- !
integer :: ind_nnd,ibeg,isize,inode_send
integer :: tag,ierr,nreq(MPI_STATUS_SIZE)
integer :: tag,ierr,nreq
integer, allocatable :: isort_node(:),irecv_array(:)
! -- process 3. -- !
integer :: iprim_remote,isize1,isize2,ia,nalpha,nj,njbeta,iglob_local
Expand Down Expand Up @@ -1477,7 +1479,7 @@ subroutine alloc_recv_array(InfoGlob,irecv_array,irecv2_array,recv_array, &
!! /----- DEBUG ------ !!

call MPI_recv(irecv_array(ibeg),isize,MPI_INTEGER,inode_send-1,tag, &
MPI_COMM_WORLD,nreq(nnd),ierr)
MPI_COMM_WORLD,nreq,ierr)
if (ierr.NE.MPI_SUCCESS) call cq_abort('Error receiving irecv_array: ', nnd, ierr)
enddo
endif
Expand Down