Conversation
bdf2581 to
577144b
Compare
There was a problem hiding this comment.
Pull request overview
This PR syncs the CI workflow configuration from the organization's central .github repository to maintain consistency across all OrrisTech repositories. The changes make lint and security checks advisory-only (non-blocking) to prevent them from failing the entire CI pipeline while existing issues are being resolved.
Changes:
- Added
continue-on-error: trueto the lint-typecheck job, making it advisory-only with explanatory comments - Added
continue-on-error: trueto the security job, making it advisory-only - Removed the
needs: [lint-typecheck]dependency from the build job, allowing it to run in parallel
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -33,12 +36,13 @@ jobs: | |||
|
|
|||
| build: | |||
| name: Build | |||
There was a problem hiding this comment.
Removing the needs: [lint-typecheck] dependency while also setting continue-on-error: true on the lint-typecheck job may cause unnecessary resource consumption. The build job will now run in parallel with lint-typecheck rather than waiting for it to complete. This means if there are linting errors (even though they won't fail the workflow), the build will still proceed and consume CI runner minutes unnecessarily. Consider keeping the needs dependency to maintain sequential execution and avoid wasting resources on builds when code quality checks haven't completed yet. The continue-on-error: true flag already ensures that lint failures won't block the overall workflow success.
| name: Build | |
| name: Build | |
| needs: [lint-typecheck] |
synced local file(s) with OrrisTech/.github.
This PR was automatically created by the org file sync workflow. It syncs the latest org standard files from the .github repo. Review the changes and merge when ready.
Changed files
.github/workflows/ci.ymlwith remotesync/.github/workflows/ci.ymlThis PR was created automatically by the repo-file-sync-action workflow run #22211856352