Skip to content

🔄 synced file(s) with OrrisTech/.github#4

Merged
iamzifei merged 1 commit intomainfrom
repo-sync/github/default
Feb 20, 2026
Merged

🔄 synced file(s) with OrrisTech/.github#4
iamzifei merged 1 commit intomainfrom
repo-sync/github/default

Conversation

@iamzifei
Copy link
Copy Markdown

@iamzifei iamzifei commented Feb 20, 2026

synced local file(s) with OrrisTech/.github.

This PR was automatically created by the org file sync workflow. It syncs the latest org standard files from the .github repo. Review the changes and merge when ready.

Changed files
  • synced local .github/workflows/ci.yml with remote sync/.github/workflows/ci.yml

This PR was created automatically by the repo-file-sync-action workflow run #22212195514

Copilot AI review requested due to automatic review settings February 20, 2026 05:14
@iamzifei iamzifei added the sync label Feb 20, 2026
@github-actions
Copy link
Copy Markdown

React Doctor Report

Click to expand results
npm warn exec The following package was not found and will be installed: react-doctor@0.0.28
react-doctor v0.0.28

�[2mScanning /home/runner/work/sora-next-web/sora-next-web...�[22m

- Detecting framework. Found �[36mNext.js�[39m.
�[32m✔�[39m Detecting framework. Found �[36mNext.js�[39m.
- Detecting React version. Found �[36mReact ^18.2.0�[39m.
�[32m✔�[39m Detecting React version. Found �[36mReact ^18.2.0�[39m.
- Detecting language. Found �[36mTypeScript�[39m.
�[32m✔�[39m Detecting language. Found �[36mTypeScript�[39m.
- Detecting React Compiler. Not found.
�[32m✔�[39m Detecting React Compiler. Not found.
- Found �[36m29�[39m source files.
�[32m✔�[39m Found �[36m29�[39m source files.

- Running lint checks...
- Detecting dead code.
�[32m✔�[39m Detecting dead code.
- Running lint checks...
�[32m✔�[39m Running lint checks.
  �[31m✗�[39m Project uses a motion library but has no prefers-reduced-motion handling — required for accessibility (WCAG 2.3.3)
�[2m    Add `useReducedMotion()` from your animation library, or a `@media (prefers-reduced-motion: reduce)` CSS query�[22m
�[2m    package.json�[22m

  �[33m⚠�[39m next/image with fill but no sizes — the browser downloads the largest image. Add a sizes attribute for responsive behavior
�[2m    Add sizes for responsive behavior: `sizes="(max-width: 768px) 100vw, 50vw"` matching your layout breakpoints�[22m
�[2m    components/Carousel.tsx: 39�[22m

  �[33m⚠�[39m Import "m" with LazyMotion instead of "motion" — saves ~30kb in bundle size�[33m (2)�[39m
�[2m    Use `import { LazyMotion, m } from "framer-motion"` with `domAnimation` features — saves ~30kb�[22m
�[2m    components/SharedModal.tsx: 10�[22m
�[2m    components/Modal.tsx: 2�[22m

  �[33m⚠�[39m Array index "index" used as key — causes bugs when list is reordered or filtered
�[2m    Use a stable unique identifier: `key={item.id}` or `key={item.slug}` — index keys break on reorder/filter�[22m
�[2m    components/SharedModal.tsx: 93�[22m

  �[33m⚠�[39m Unused file�[33m (2)�[39m
�[2m    This file is not imported by any other file in the project.�[22m
�[2m    utils/generateBlurPlaceholder.ts�[22m
�[2m    components/Icons/Logo.tsx�[22m

  �[2m┌──────────────────────────────────────────────────────┐�[22m
  �[2m│�[22m �[32m┌─────┐�[39m                                              �[2m│�[22m
  �[2m│�[22m �[32m│ ◠ ◠ │�[39m                                              �[2m│�[22m
  �[2m│�[22m �[32m│  ▽  │�[39m                                              �[2m│�[22m
  �[2m│�[22m �[32m└─────┘�[39m                                              �[2m│�[22m
  �[2m│�[22m React Doctor �[2m(www.react.doctor)�[22m                      �[2m│�[22m
  �[2m│�[22m                                                      �[2m│�[22m
  �[2m│�[22m �[32m96�[39m / 100  �[32mGreat�[39m                                      �[2m│�[22m
  �[2m│�[22m                                                      �[2m│�[22m
  �[2m│�[22m �[32m████████████████████████████████████████████████�[39m�[2m░░�[22m   �[2m│�[22m
  �[2m│�[22m                                                      �[2m│�[22m
  �[2m│�[22m �[31m✗ 1 error�[39m  �[33m⚠ 6 warnings�[39m  �[2macross 6/29 files�[22m  �[2min 356ms�[22m �[2m│�[22m
  �[2m└──────────────────────────────────────────────────────┘�[22m

�[2m  Full diagnostics written to /tmp/react-doctor-c98af10a-4c90-4db1-a18e-84e78e9d030c�[22m

�[2m  Share your results: �[36mhttps://www.react.doctor/share?p=sora-next-web&s=96&e=1&w=6&f=6�[39m�[22m

Powered by react-doctor

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs the CI workflow configuration from the organization's central .github repository. The change removes continue-on-error: true flags from the lint-typecheck and security audit jobs, which fundamentally changes their behavior from advisory-only to blocking.

Changes:

  • Removed continue-on-error: true from the lint-typecheck job
  • Removed continue-on-error: true from the security audit job
  • Updated comments to state that lack of needs: dependencies means failures won't block CI

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# Advisory only — does not block build or other jobs.
# Remove continue-on-error once repo lint errors are resolved.
continue-on-error: true
# No "needs:" from other jobs, so failures here won't block CI.
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is misleading. Removing "continue-on-error: true" means failures in this job WILL cause the overall CI workflow to fail. The absence of "needs:" means other jobs won't be blocked from running, but the workflow status will still be marked as failed if this job fails. If the intent is to keep this job advisory-only (not blocking CI status), "continue-on-error: true" should be retained.

Copilot uses AI. Check for mistakes.
name: Security Audit
# Advisory only — does not block other jobs.
continue-on-error: true
# No "needs:" from other jobs, so failures here won't block CI.
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is misleading. Removing "continue-on-error: true" means failures in this job WILL cause the overall CI workflow to fail. The absence of "needs:" means other jobs won't be blocked from running, but the workflow status will still be marked as failed if this job fails. If the intent is to keep this job advisory-only (not blocking CI status), "continue-on-error: true" should be retained.

Copilot uses AI. Check for mistakes.
@iamzifei iamzifei merged commit 5fd8608 into main Feb 20, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants