Conversation
f55eff7 to
53936ab
Compare
React Doctor ReportClick to expand results
|
There was a problem hiding this comment.
Pull request overview
This PR syncs the CI workflow configuration from the organization's central .github repository. The change removes continue-on-error: true flags from the lint-typecheck and security audit jobs, which fundamentally changes their behavior from advisory-only to blocking.
Changes:
- Removed
continue-on-error: truefrom the lint-typecheck job - Removed
continue-on-error: truefrom the security audit job - Updated comments to state that lack of
needs:dependencies means failures won't block CI
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Advisory only — does not block build or other jobs. | ||
| # Remove continue-on-error once repo lint errors are resolved. | ||
| continue-on-error: true | ||
| # No "needs:" from other jobs, so failures here won't block CI. |
There was a problem hiding this comment.
This comment is misleading. Removing "continue-on-error: true" means failures in this job WILL cause the overall CI workflow to fail. The absence of "needs:" means other jobs won't be blocked from running, but the workflow status will still be marked as failed if this job fails. If the intent is to keep this job advisory-only (not blocking CI status), "continue-on-error: true" should be retained.
| name: Security Audit | ||
| # Advisory only — does not block other jobs. | ||
| continue-on-error: true | ||
| # No "needs:" from other jobs, so failures here won't block CI. |
There was a problem hiding this comment.
This comment is misleading. Removing "continue-on-error: true" means failures in this job WILL cause the overall CI workflow to fail. The absence of "needs:" means other jobs won't be blocked from running, but the workflow status will still be marked as failed if this job fails. If the intent is to keep this job advisory-only (not blocking CI status), "continue-on-error: true" should be retained.
synced local file(s) with OrrisTech/.github.
This PR was automatically created by the org file sync workflow. It syncs the latest org standard files from the .github repo. Review the changes and merge when ready.
Changed files
.github/workflows/ci.ymlwith remotesync/.github/workflows/ci.ymlThis PR was created automatically by the repo-file-sync-action workflow run #22212195514