Resample v2 clean #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 2018-12-05 @max-sixty GitHub reviews for resample-v2-clean pull request). Not cleaned.
Get PEP8 changes from Ouranosinc.
…-v2-clean # Conflicts: # xarray/tests/test_cftimeindex_resample.py
… 2018-12-05 @max-sixty GitHub reviews for resample-v2-clean pull request). Cleaned.
# Conflicts: # xarray/core/resample.py # xarray/tests/test_cftimeindex_resample.py
Author
|
I was expecting 52 assertion failures from the 304 tests in test_cftimeindex_resample.py but Travis CI says that all of them are failing. The failures all seem to be due to: Can I go ahead and merge the pull request? |
|
Sure thing. If anything is off, the upstream maintainers will let us know. For the |
Zeitsperre
approved these changes
Dec 18, 2018
aulemahal
pushed a commit
that referenced
this pull request
Mar 3, 2025
* finalize release notes * add contributors * Tweak main what's new entry for time coding (#4) --------- Co-authored-by: Spencer Clark <spencerkclark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issues raised in
pydata#2593
Upsampling method changes in resample_cftime.py.