[TEST] Golden file test infrastructure for JSON Schema baselines#471
Open
Seth Fitzsimmons (mojodna) wants to merge 1 commit intodevfrom
Open
[TEST] Golden file test infrastructure for JSON Schema baselines#471Seth Fitzsimmons (mojodna) wants to merge 1 commit intodevfrom
Seth Fitzsimmons (mojodna) wants to merge 1 commit intodevfrom
Conversation
tests/golden_support.py: assert_golden compares strings against golden files with unified diff on mismatch. assert_json_schema_golden generates a Pydantic JSON Schema and delegates to assert_golden. Root conftest.py registers --update-baselines flag and update_baselines fixture. Baseline marker registered in pyproject.toml for selective test runs. Signed-off-by: Seth Fitzsimmons <sethfitz@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts shared golden-file comparison boilerplate from 16 JSON Schema baseline tests into
tests/golden_support.py, reducing each test to a declarative call.Changes:
tests/golden_support.py:assert_goldencompares strings against golden files with unified diff on mismatch;assert_json_schema_goldengenerates a Pydantic JSON Schema and delegates toassert_goldenconftest.py: registers--update-baselinesflag andupdate_baselinesfixturepyproject.toml: registersbaselinemarker for selective test runsNet: -128 lines across test files.
Closes #470