Skip to content

Address feedback: ubuntu-slim is a valid runner label in docs preview workflow#481

Closed
Copilot wants to merge 1 commit intojmccall-schema-docs-publishfrom
copilot/sub-pr-473
Closed

Address feedback: ubuntu-slim is a valid runner label in docs preview workflow#481
Copilot wants to merge 1 commit intojmccall-schema-docs-publishfrom
copilot/sub-pr-473

Conversation

Copy link

Copilot AI commented Mar 23, 2026

Description

The automated Copilot reviewer incorrectly flagged ubuntu-slim as an invalid GitHub-hosted runner label in .github/workflows/schema-pr-preview.yml. This label is a valid self-hosted runner registered in the OvertureMaps org — no code change is required. This PR acknowledges the feedback, corrects the false-positive review comment, and stores the fact to prevent future incorrect flagging.

Reference

  1. Original PR: [FEATURE] Docs preview for schema changes #473
  2. Triggering review comment: [FEATURE] Docs preview for schema changes #473 (comment)

Testing

No functional change. The workflow already uses ubuntu-slim correctly; the runner label is confirmed valid for this org.

Checklist

  1. Add relevant examples.
  2. Add relevant counterexamples.
  3. Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
  4. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  5. Update Docusaurus documentation, if an update is required.
  6. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation website

Docs preview for this PR.


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Copilot AI changed the title [WIP] [WIP] Address feedback on runner label validation in docs preview feature Address feedback: ubuntu-slim is a valid runner label in docs preview workflow Mar 23, 2026
@github-actions
Copy link

🗺️ Schema reference docs preview is live!

🌍 Preview https://staging.overturemaps.org/schema/pr/481/schema/index.html
🕐 Updated Mar 23, 2026 16:20 UTC
📝 Commit 92e8d04
🔧 env SCHEMA_PREVIEW true

Note

♻️ This preview updates automatically with each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants