Merged
Conversation
1. a new variable is introduced "lastDownId". 2. This variable is used to track the last pressed button. In case of "holds" the button HAS to be the last one pressed, this is the case on all the official games. 3. This will fix the syndrome "just hold R2 / L2 to get the full hold score".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bought the MM+ game, hoping that it will make this project obsolete. Got disappointed by the latency, decided to try and fix the cursed issue, that is "holds" 😂.
Surprisingly, this was an easy fix. I hope it's 100% done, but I need more testing...
If there's anything breaking, let me know...
Btw, thanks for everyone who made this project possible, I'm sure everyone is busy, but I'm happy to be able to contribute this fix (if it works perfectly).
Edit: It works very well for me, but it might not work for everyone. so let me know...