Skip to content

Conversation

@PaulJonasJost
Copy link
Collaborator

Now possible to fill the parameter values from the sbml model

@PaulJonasJost PaulJonasJost requested a review from Copilot April 25, 2025 13:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the PEtab model by integrating SBML‐based default value determination into the parameter table. Key changes include initializing and passing the SBML viewer model, updating default value retrieval functions to accept an additional changes parameter, and propagating these updates across related controllers and commands.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/petab_gui/models/petab_model.py Instantiates the SBML viewer and passes it to the ParameterModel
src/petab_gui/models/pandas_table_model.py Updates default value logic to accept a “changed” dict and reorders columns
src/petab_gui/controllers/* Propagates SBML default value updates and connection adjustments
src/petab_gui/commands.py Adjusts new row initialization to use np.nan instead of empty strings
src/petab_gui/C.py Introduces the SBML_LOOK strategy for nominal value defaults
Comments suppressed due to low confidence (1)

src/petab_gui/commands.py:102

  • [nitpick] Replacing empty strings with np.nan when inserting new rows may affect downstream logic that depends on string placeholders. Verify that downstream processing and validations handle np.nan values correctly.
df.loc[idx] = [np.nan] * df.shape[1]

@PaulJonasJost PaulJonasJost merged commit 206e930 into develop Apr 25, 2025
@PaulJonasJost PaulJonasJost deleted the default_from_sbml_model branch May 7, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants