-
Notifications
You must be signed in to change notification settings - Fork 1
small_stuff #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
small_stuff #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR makes several improvements including documentation updates, removal of redundant code, and various code style enhancements.
- Updated and reformatted settings, logging, and command modules.
- Minor refactoring in the find/replace, context menu, and controller routines.
- Adjusted configuration constants and project setup files.
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/petab_gui/views/find_replace_bar.py | Updated UI interactions and search logic; note a potential issue with logical operators. |
| src/petab_gui/views/context_menu_mananger.py | Added context menu functionality; the file name appears to be misspelled. |
| src/petab_gui/settings_manager.py | Reformatting and improved coding style. |
| ... | Other files: primarily style and formatting improvements supporting documentation and code cleanup. |
Comments suppressed due to low confidence (1)
src/petab_gui/views/context_menu_mananger.py:4
- The filename 'context_menu_mananger.py' appears to be misspelled; consider renaming it to 'context_menu_manager.py' for consistency and clarity.
class ContextMenuManager:
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited some documentation with a PyCharm AI and did my ruff checks. Also removed unnecessary code.