Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 4, 2024

@dweindl dweindl force-pushed the fix_588_schema branch 2 times, most recently from 7a8fe3a to 51de161 Compare December 4, 2024 10:18
@dweindl dweindl marked this pull request as ready for review December 4, 2024 10:20
@dweindl dweindl requested a review from a team as a code owner December 4, 2024 10:20
@dilpath
Copy link
Member

dilpath commented Dec 4, 2024

The links currently start a download in Firefox. We could try to render them in the docs or link to where they can be viewed on GitHub?

@dweindl
Copy link
Member Author

dweindl commented Dec 4, 2024

render them in the docs

Done.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dweindl dweindl merged commit b9e141d into main Dec 4, 2024
1 check passed
@dweindl dweindl deleted the fix_588_schema branch December 4, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PEtab yaml file schema missing / broken links

3 participants