Skip to content

Conversation

@sebapersson
Copy link
Contributor

Following the discussions at the editor meetings, this PR removes initializationPrior from the parameter table, and renames objectivePriorType to prior.

@sebapersson sebapersson requested a review from a team as a code owner March 25, 2025 12:28
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
@dweindl dweindl added this to the PEtab 2.0.0 milestone Mar 25, 2025
@dweindl
Copy link
Member

dweindl commented Mar 25, 2025

Please add a brief summary to the "Changes" section.

Something like:

  • initializationPrior{Type,Parameters} columns were removed from the parameters table because this was beyond the definition of the parameter estimation problem, and was a source of confusion
  • objectivePriorType and objectivePriorParameters in the parameters table have been renamed to prior and priorParameters, respectively.

@sebapersson
Copy link
Contributor Author

sebapersson commented Mar 25, 2025

Please add a brief summary to the "Changes" section.

Thanks for noticing. I have now added a short summary in the changes section. If it looks good, feel free to merge, then I will update #595

@dweindl dweindl merged commit 9d17fb6 into PEtab-dev:main Mar 26, 2025
2 checks passed
@sebapersson sebapersson deleted the prior_rename_drop_init branch March 26, 2025 10:21
@dweindl
Copy link
Member

dweindl commented Mar 26, 2025

then I will update #595

Go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants