Remove SBML local parameter mapping #663
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed during a recent PEtab editor meeting, we don't want to support SBML local parameters via the mapping table, as this just introduces unnecessary complexity. Instead of aliasing local parameters via the PEtab mapping table, they should just be implemented as global parameters in the SBML model to begin with.
Contributor
matthiaskoenig
left a comment
matthiaskoenig
left a comment
There was a problem hiding this comment.
This looks good. We could perhaps add a sentence/clarification in the spec along the lines of:
SBML local parameters are not supported. Local parameters should be promoted to global parameters (e.g. using libsbml).
This could be as part of the parameter description.
matthiaskoenig
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during a recent PEtab editor meeting, we don't want to support SBML local parameters via the mapping table, as this just introduces unnecessary complexity. Instead of aliasing local parameters via the PEtab mapping table, they should just be implemented as global parameters in the SBML model to begin with.