Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jan 26, 2026

Make library compatible with pandas 3.0.

Closes #469.

Make library compatible with pandas 3.0.

Closes PEtab-dev#469.
@dweindl dweindl self-assigned this Jan 26, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.46%. Comparing base (441d9f6) to head (b58dfda).

Files with missing lines Patch % Lines
petab/v1/lint.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
+ Coverage   75.41%   75.46%   +0.04%     
==========================================
  Files          62       62              
  Lines        6895     6895              
  Branches     1227     1227              
==========================================
+ Hits         5200     5203       +3     
+ Misses       1225     1221       -4     
- Partials      470      471       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review January 26, 2026 14:34
@dweindl dweindl requested a review from a team as a code owner January 26, 2026 14:34
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All edits in this file are in repeated code but fine as is

Comment on lines 510 to 512
pd.testing.assert_frame_equal(
problem.observable_df, observable_df_expected
problem.observable_df, observable_df_expected, check_dtype=False
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why False? Could add a brief comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatible with pandas 3.0

3 participants