README: write up the functionality in this repo#25
Conversation
|
@fredden If you have the time, I wouldn't mind if you could look this over... |
fredden
left a comment
There was a problem hiding this comment.
Looks good to me. The words make sense and it's good to get the intent documented.
For the files required to trigger the various workflows, having an asterisk in the filename doesn't look right. If I were to create a file actually called phpstan.neon* or .yamllint.y*ml (which are a perfectly valid file names in Linux), then my guess is that the respective workflows would not actually trigger. Can we list the real filenames that would trigger the workflow?
Actually, they probably would as the config file check is just a glob pattern. Then again, the results may not be as expected as the tooling itself may not pick up on the config file correctly 😁
👍🏻 Done. |
fredden
left a comment
There was a problem hiding this comment.
Should we update the globs in the workflow files to match these new more specific definitions of matching files?
Includes updating the documentation about this in the README.
32b9944 to
fdacf63
Compare
No description provided.