Conversation
Contributor
dcolombara
commented
Mar 14, 2025
dcolombara
commented
- Improved documentation with detailed Roxygen headers
- Fixed logic error for handling NA/missing cat2_group values
- Replaced tidyr::crossing with data.table for better performance
- Added input validation with helpful error messages
- Implemented progressr tracking across functions
- Renamed proto_ prefix files to indicate production-ready status
- Harmonized catnum/catgroup/catvarname usage across functions
- Produced 2023 adolescent birth rate and infant mortality rates as a test
- Passed devtools::check()
Version 0.0.2
- new validations - built in more tweaks for race3 headaches - dropped dependency on tidyr::crossing - progress meter - better documentation / comments
- improved roxygen2 header - simplified / tidier code, but same fundamental logic / structure
- file is now called chi_generate_instructions_pop
* Improved documentation with detailed Roxygen comments * Added input validation with helpful error messages * Clearer section comments * Replaced tidyr::crossing with data.table * progressr progress tracking * Standardized variable naming * Improved work with categorical variables and crosswalks
- previous logic for dropping when cat2_group was NA / 'NA' and cat1 group NOT NA / 'NA' was flawed
- just rename because now fully functional
- changed references to 'key' column to 'mykey' because `key` is reserved (or maybe should be reserved) by data.table
- drop proto prefix because fully documented & updated
- now use `catnum`, `catgroup`, and `catvarname` in a standard way across functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.