Adding unit tests and more complex testing data

tests/testthat/test-chi_generate_analysis_set.R

@@ -4,3 +4,11 @@ test_that("chi_generate_analysis_set validates inputs", {
   expect_error(chi_generate_analysis_set(data_source = 123), "data_source must be a single character string")
   expect_error(chi_generate_analysis_set(CHIestimates = 123), "CHIestimates must be a data.table or data.frame")
 })
+
+test_that("chi_generate_analysis_set generates expected analysis set from CHI estimates", {
+  TestData <- setup_test_data()
+  DT_test_analysis_instructions_results <- apde.chi.tools::chi_generate_tro_shell(TestData$my.analysis_set_twosets, end.year = 2023, year.span = 3, trend.span = 3, trend.periods = 5)
+  DT_test_chi_calc_output <- suppressWarnings(apde.chi.tools::chi_calc(ph.data =  TestData$my.generic_data, ph.instructions = DT_test_analysis_instructions_results, source_name =  "generic_test", source_date = as.Date("2025-04-10"), ci = .80))
+  DT_recreated_analysis_set <- suppressWarnings(chi_generate_analysis_set(CHIestimates = DT_test_chi_calc_output))
+  expect_equal(all.equal(TestData$my.analysis_set_twosets[order(cat1,set)] , DT_recreated_analysis_set[order(cat1,set)]),TRUE)
+})

tests/testthat/test-chi_sql_update.R

@@ -2,17 +2,21 @@
 test_that("chi_update_sql validates inputs", {
   test_data <- setup_test_data()
 
-  expect_warning(
-    chi_update_sql(
-      CHIestimates = test_data$my.estimate,
-      CHImetadata = test_data$my.metadata,
-      table_name = 'JustTesting',
-      server = 'development',
-      replace_table = FALSE
-    ),
-    "Validation may be flawed for the following variables because they are 100% missing"
-  )
-
+  con_status <- test_data$my.hhsaw_status_test()
+  if(con_status == 1) {
+    expect_warning(
+      chi_update_sql(
+        CHIestimates = test_data$my.estimate,
+        CHImetadata = test_data$my.metadata,
+        table_name = 'JustTesting',
+        server = 'development',
+        replace_table = FALSE
+      ),
+      "Validation may be flawed for the following variables because they are 100% missing"
+    )
+  } else {
+    message("connection test skipped")
+  }
   expect_error(chi_update_sql(),
                "The results table to push to SQL \\(CHIestimates\\) is missing")
   expect_error(suppressWarnings(chi_update_sql(CHIestimates = test_data$my.estimate)),

tests/testthat/test_chi_generate_metadata.R

@@ -4,4 +4,10 @@ test_that("chi_generate_metadata handles valid inputs", {
 
   expect_error(chi_generate_metadata(), "meta.old must be provided")
   expect_error(chi_generate_metadata(meta.old = test_data$my.metadata), "est.current must be provided")
+
+  # why does this test fail? the DTs are not properly constructed, perhaps I need to update packages? will try later
+  #DTtest <- test_data$my.estimate
+  #DTtest[tab,] # throws error
+  #chi_generate_metadata(meta.old = test_data$my.metadata, est.current = test_data$my.estimate)
+
 })