Conversation
Contributor
dcolombara
commented
May 9, 2025
dcolombara
commented
- based heavily on rads::suppress
- main improvement is that it suppresses on denominators (not just numerators)
- also add caution when numerator == 0
- more validation
- more customizable arguments, but defaults are for CHI output
- many more tests
- passes all tests without errors or warnings in devtools::check()
- based heavily on rads::suppress - main improvement is that it suppresses on denominators (not just numerators) - also add caution when numerator == 0 - more validation - more customizable arguments, but defaults are for CHI output - many more tests - passes all tests without errors or warnings in devtools::check()
Collaborator
|
This doesn't "NULL" "comparison_wiht_kc" on suprression, but the spec specifies that this column should be nulled. |
- added to the columns_to_suppress default - no other changes needed because validation of columns_to_suppress already notifies of missing columns and will remove from columns_to_suppress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.