[Cleanup] Remove redundant and unused code#1467
Merged
Merged
Conversation
`SPORK_10_MASTERNODE_PAY_UPDATED_NODES` has remained active for the past 3+ years through multiple protocol updates and was largely already deprecated at the time we code-forked from DASH. Since the masternode broadcast message was introduced, the only remaining practical use of SPORK_10 was a redundant if/else that this PR removes. Additionally, since the masternode broadcast message was introduced, we no longer need to continue supporting the already deprecated `dsee` and `dseep` network messages, which were themselves only ever used when SPORK_10 was inactive.
furszy
approved these changes
Mar 30, 2020
akshaynexus
added a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 30, 2020
a07dee4 [Cleanup] Remove redundant and unused code (Fuzzbawls) Pull request description: `SPORK_10_MASTERNODE_PAY_UPDATED_NODES` has remained active for the past 3+ years through multiple protocol updates and was largely already deprecated at the time we code-forked from DASH. Since the masternode broadcast message was introduced, the only remaining practical use of SPORK_10 was a redundant if/else that this PR removes. Additionally, since the masternode broadcast message was introduced, we no longer need to continue supporting the already deprecated `dsee` and `dseep` network messages, which were themselves only ever used when SPORK_10 was inactive. ACKs for top commit: random-zebra: ACK a07dee4 furszy: utACK a07dee4 Tree-SHA512: 16e5b98a7dcaf747cb5d688aa389e604e5840e4af0bfb92a45ad87037ac108c844fe1360227c4ba87371eb629569bab144849b3bdcbc7b1b970c20460ae22b6d
1 task
This was referenced Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPORK_10_MASTERNODE_PAY_UPDATED_NODEShas remained active for the past3+ years through multiple protocol updates and was largely already
deprecated at the time we code-forked from DASH.
Since the masternode broadcast message was introduced, the only remaining
practical use of SPORK_10 was a redundant if/else that this PR removes.
Additionally, since the masternode broadcast message was introduced,
we no longer need to continue supporting the already deprecated
dseeand
dseepnetwork messages, which were themselves only ever used whenSPORK_10 was inactive.