Base work for the Sapling signatureHash#1666
Merged
Merged
Conversation
furszy
force-pushed
the
2020_pip143
branch
2 times, most recently
from
c647a16 to
1b3742a
Compare
random-zebra
previously approved these changes
Jul 22, 2020
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
ACK 3ae13420adbea25d1852962a0cd49dff37c33812
Collaborator
|
needs a rebase as #1700 being merged introduced new code in |
Coming from btc@bd0f41387783ee91623d7fac15e89e57db37df82
This is a preparation for BIP143 support. -- Edited for PIVX merge -- Coming from btc@0ef1dd3e11dd573b6e443852ef0c72e34093ac68
Removing deprecated accounts checks and the hardcoded serialization.
Coming from btc@d2c5d044d00ec805957ab246a7863d83ca075805
Coming from btc@7ef8f3c072a8750c72a3a1cdc727b5c1d173bac8
Coming from btc@ab48c5e72156b34300db4a6521cb3c9969be3937
Coming from btc@35fe0393f216aa6020fc929272118eade5628636
Author
|
Good, rebased + updated to latest master. |
Fuzzbawls
approved these changes
Aug 5, 2020
furszy
added a commit
that referenced
this pull request
Aug 21, 2020
…values e02edd3 Cleaning isminetype::ISMINE_SPENDABLE_STAKEABLE. (furszy) 1bf9dc4 wallet: unify GetUnspentCredit with GetCredit (furszy) 9f2ae47 wallet: remove currently unused UpdateAmount method. (furszy) bef69d3 wallet: add cachable amounts for caching credit/debit values (furszy) 8f2a156 Make IsMine stop distinguishing solvable/unsolvable (furszy) e541593 Make coincontrol use IsSolvable to determine solvability (furszy) e1a0cfb Back port of IsSolvable to check scripts solvability. (furszy) Pull request description: Built on top of #1755 and #1666 . The goal of this PR has been to improve the `CWalletTx` to be able to add shielded cached balances in a much cleaner way. Including the following changes: * Adapted IsSolvable function from 0c8ea63 (without the witness check. Only used to check regular outputs to be able to decouple the output solvability from `ismine.h` enum) * Solvability decoupled from `ismine.h`. Back ported 6d714c3 and 4e91820 from bitcoin#13142. * And lastly, adapted bitcoin#15780 beauty cleanup to our sources. ACKs for top commit: random-zebra: utACK e02edd3 Tree-SHA512: 3c54397585f2ce1a47a5a86292216b5beab6cbf1e4ad6c289a1daa958cf4c535855bac1e13a7de290bd8d374abef3da7a909b11ee0f5016af31e90f642b448d5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base work for the new transaction digest algorithm for signature verification on PIVX Sapling transactions.
Essentially, an implementation of BIP143 + few more good commits that found down the rabbit hole.
Back ports:
Next step over this area (need 1553 merged to be able to push it) is the further specialization of BIP143 into our custom implementation of ZIP143 (with a different digest algorithm definition using our tx data and hash personalization).