Coin control dialog utxo processing/update flow large cleanup and improvements#1977
Conversation
…unt of arguments in the function signature.
…followup loop over the returned vector.
|
Added more cleanups. This got bigger than what expected. |
furszy
force-pushed
the
2020_improve_coin_control_update
branch
from
d6f06ea to
4df5872
Compare
|
pushed one more time, ready for review. |
|
Commit 561de4d7dea630d996815a1ffb08822189ecd621 makes it so that "change" outputs (when not specifying a custom change address) are no longer properly designated as such in either view mode. They instead show with a |
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Code review ACK up till 750858b3b8ab806bac87df29fc45876b34badf35
Really nice improvements, left just some minor notes.
This removes the tooltip for change address, showing where the change is coming from.
But I think that the performance gain beats the usefulness of such info (can't think of any possible use case, now that the account system is removed)
…riginated the change
…values to the top of the method.
…at is retrieved by ListCoins
…dress == sWalletAddress` has been always true.
…loop over it and then return it.
… badly coded function.
…lculation. Our reference client is not creating them by default. Most likely never did it.
…d. Our minimum version is qt5.5
… be able to return unspent notes in the future as well.
|
yep agree. Going to add the change empty label in a much straightforward manner and done. |
…for the change outputs
furszy
force-pushed
the
2020_improve_coin_control_update
branch
from
7f0328c to
71e1f98
Compare
|
Updated per feedback. Added the change label. |
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Nice stuff 🥃 ACK 71e1f98
The change addresses still report "(no label)" in tree mode (as that is set before calling loadAvailableCoin) but no big deal.
4 participants
Base initial work in order to be able to generalize
CoinControlDialogup to the point of introducing shielded notes selection (being developed in the Sapling GUI PR #1963).Found several redundancies and not so good code over the overall
CoinControlDialogclass. So.. have re-structured it in a large percentage, aiming to improve the performance and clean all of the inefficiencies.