[Build] Package sapling params in repo/release#2022
Merged
Conversation
random-zebra
previously approved these changes
Dec 5, 2020
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Linux and Windows gitian builds tested. Awesome job. ACK 3b8289c906d9b04c920d65a0bc902128dd42f1ba
Since we no longer require the sprout params, we can package the sapling params inside the source repository (and the release binaries) until such time that the client has the ability to fetch these params directly from the P2P network. Overview of the changes here per-OS: - macOS release binaries will use the params that are bundled into the `.app` bundle - Windows installer `.exe` will automatically install the params into the appdata directory. - linux PPA/Snap/Copr installs will automatically install the params into the appropriate directory (either `$SNAP_USER_COMMON/.pivx-params` or `/usr/local/share` - Linux tarballs include a bash shell script that can be run to install the params files into `$HOME/.pivx-params` Note: Windows users that choose to use the `.zip` binary package will need to manually copy the params files to the appropriate `AppData` directory on their own (to be documented later)
Fuzzbawls
force-pushed
the
2020_params-dist
branch
from
3b8289c to
3e641c1
Compare
Collaborator
Author
|
pushed a small update to include the |
random-zebra
added a commit
that referenced
this pull request
Dec 7, 2020
2109aec [Build] Proper coverage for ppa, local, and snapcraft (Fuzzbawls) Pull request description: Followup to #2022 to resolve the lingering issues with ppa/snapcraft builds. build-log of a PPA build can be seen [here](https://launchpadlibrarian.net/510054528/buildlog_ubuntu-bionic-amd64.pivx_4.3.99~202012060757+gitdc5ad4478~ubuntu18.04.1_BUILDING.txt.gz) This also introduces proper `desktop-launch` wrapping for the nightly snapcraft builds, which is required to successfully open the GUI wallet from the snap commands. ACKs for top commit: furszy: utACK 2109aec random-zebra: utACK 2109aec and merging... Tree-SHA512: e113e1037ade34cf5b23548538c2ecdb1d838edaa6ccd7020541ca1f84555e04b24ba9b9cc80424c0c10d15318030644c90924e3adfb453fc62fc49546c71724
random-zebra
added a commit
that referenced
this pull request
Dec 9, 2020
… framework. 9afec2e CMakeList, pivxd and test_pivx fix for missing MacOS framework. (furszy) Pull request description: Without the framework include, CMake isn't able to find the `CFBundleGetMainBundle` and relative classes/functions. Thus why isn't compiling pivxd and the unit test target. Dependency included due #2022 changes. ACKs for top commit: Fuzzbawls: utACK 9afec2e random-zebra: utACK 9afec2e and merging... Tree-SHA512: a872a78738b579b28f1b05fe61e2980c7c1ddd197f3412687f8835f10a12e3ac58c3c97c6c7074c2674359193629ea38f96f2bd17565dae9d59052889c089b10
Fuzzbawls
added
the
Needs Release Notes
random-zebra
removed
the
Needs Release Notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we no longer require the sprout params, we can package the sapling params inside the source repository (and the release binaries) until such time that the client has the ability to fetch these params directly from the P2P network.
Overview of the changes here per-OS:
.appbundle.exewill automatically install the params into the AppData directory.$SNAP_USER_COMMON/.pivx-paramsor/usr/local/share)$HOME/.pivx-paramsNote: Windows users that choose to use the
.zipbinary package will need to manually copy the params files to the appropriateAppDatadirectory on their own (to be documented later)The
install-params.shscript is also run-able on linux/macOS from repository clones or source tarball paths to install the params into the OS-appropriate location for future use.