Skip to content

[Test] Adding sapling transaction validation unit test coverage. #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
random-zebra merged 1 commit into from
Dec 9, 2020
Merged

[Test] Adding sapling transaction validation unit test coverage. #2042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ set(BITCOIN_TESTS
${CMAKE_CURRENT_SOURCE_DIR}/uint256_tests.cpp
${CMAKE_CURRENT_SOURCE_DIR}/univalue_tests.cpp
${CMAKE_CURRENT_SOURCE_DIR}/util_tests.cpp
${CMAKE_CURRENT_SOURCE_DIR}/validation_tests.cpp
${CMAKE_CURRENT_SOURCE_DIR}/sha256compress_tests.cpp
${CMAKE_CURRENT_SOURCE_DIR}/upgrades_tests.cpp
${CMAKE_CURRENT_SOURCE_DIR}/librust/sapling_rpc_wallet_tests.cpp
Expand Down
95 changes: 95 additions & 0 deletions src/test/validation_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#include "test/test_pivx.h"
#include "primitives/transaction.h"
#include "sapling/sapling_validation.h"
#include "tiertwo/specialtx_validation.h"
#include "test/librust/utiltest.h"

Expand Down Expand Up @@ -58,4 +59,98 @@ BOOST_AUTO_TEST_CASE(special_tx_validation_test)
RegtestDeactivateSapling();
}

void test_simple_sapling_invalidity(CMutableTransaction& tx)
{
CAmount nDummyValueOut;
{
CMutableTransaction newTx(tx);
CValidationState state;

BOOST_CHECK(!CheckTransaction(newTx, false, false, state, false));
BOOST_CHECK(state.GetRejectReason() == "bad-txns-vin-empty");
}
{
CMutableTransaction newTx(tx);
CValidationState state;

newTx.sapData->vShieldedSpend.emplace_back();
newTx.sapData->vShieldedSpend[0].nullifier = GetRandHash();

BOOST_CHECK(!CheckTransaction(newTx, false, false, state, false));
BOOST_CHECK(state.GetRejectReason() == "bad-txns-vout-empty");
}
{
// Ensure that nullifiers are never duplicated within a transaction.
CMutableTransaction newTx(tx);
CValidationState state;

newTx.sapData->vShieldedSpend.emplace_back();
newTx.sapData->vShieldedSpend[0].nullifier = GetRandHash();

newTx.sapData->vShieldedOutput.emplace_back();

newTx.sapData->vShieldedSpend.emplace_back();
newTx.sapData->vShieldedSpend[1].nullifier = newTx.sapData->vShieldedSpend[0].nullifier;

BOOST_CHECK(!SaplingValidation::CheckTransactionWithoutProofVerification(newTx, state, nDummyValueOut));
BOOST_CHECK(state.GetRejectReason() == "bad-spend-description-nullifiers-duplicate");

newTx.sapData->vShieldedSpend[1].nullifier = GetRandHash();

BOOST_CHECK(SaplingValidation::CheckTransactionWithoutProofVerification(newTx, state, nDummyValueOut));
}
{
CMutableTransaction newTx(tx);
CValidationState state;

// Create a coinbase transaction
CTxIn vin;
vin.prevout = COutPoint();
newTx.vin.emplace_back(vin);
CTxOut vout;
vout.nValue = 2;
newTx.vout.emplace_back(vout);

newTx.sapData->vShieldedSpend.emplace_back();

BOOST_CHECK(!CheckTransaction(newTx, false, false, state, false, false, true));
BOOST_CHECK(state.GetRejectReason() == "bad-txns-invalid-sapling");
}
{
CMutableTransaction newTx(tx);
CValidationState state;

// Create a coinstake transaction
CTxIn vin;
vin.prevout = COutPoint(UINT256_ZERO, 0);
newTx.vin.emplace_back(vin);
CTxOut vout;
vout.nValue = 0;
newTx.vout.emplace_back(vout);
vout.nValue = 2;
newTx.vout.emplace_back(vout);

newTx.sapData->vShieldedSpend.emplace_back();

BOOST_CHECK(!CheckTransaction(newTx, false, false, state, false, false, true));
BOOST_CHECK(state.GetRejectReason() == "bad-txns-invalid-sapling");
}
}

BOOST_AUTO_TEST_CASE(test_simple_shielded_invalid)
{
// Switch to regtest parameters so we can activate Sapling
SelectParams(CBaseChainParams::REGTEST);

CMutableTransaction mtx;
mtx.nVersion = CTransaction::TxVersion::SAPLING;

UpdateNetworkUpgradeParameters(Consensus::UPGRADE_V5_0, Consensus::NetworkUpgrade::ALWAYS_ACTIVE);
test_simple_sapling_invalidity(mtx);
UpdateNetworkUpgradeParameters(Consensus::UPGRADE_V5_0, Consensus::NetworkUpgrade::NO_ACTIVATION_HEIGHT);

// Switch back to mainnet parameters as originally selected in test fixture
SelectParams(CBaseChainParams::MAIN);
}

BOOST_AUTO_TEST_SUITE_END()