[Wallet] Making CWalletTx store TransactionRef.#2044
Merged
furszy merged 3 commits intoJan 29, 2021
Conversation
furszy
force-pushed
the
2020_making_cwllettx_store_txref
branch
from
8a64ace to
d5f4a06
Compare
Fuzzbawls
changed the title
furszy
changed the title
furszy
force-pushed
the
2020_making_cwllettx_store_txref
branch
from
d5f4a06 to
3adfd60
Compare
Author
|
Rebased on master + completed the work. |
furszy
force-pushed
the
2020_making_cwllettx_store_txref
branch
from
3adfd60 to
501edb9
Compare
random-zebra
previously approved these changes
Jan 22, 2021
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Minor concern over the newly introduced IsNormalTx function.
Otherwise looking good, utACK 501edb9a579a68d5781e8d14866802ceb1436a79
furszy
force-pushed
the
2020_making_cwllettx_store_txref
branch
from
501edb9 to
7ecef96
Compare
furszy
requested review from
Fuzzbawls and
random-zebra
and removed request for
Fuzzbawls
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
utACK 7ecef9679a0b1d524d3016bae8f9a910ca5bb2ee
furszy
force-pushed
the
2020_making_cwllettx_store_txref
branch
from
7ecef96 to
652981a
Compare
Fuzzbawls
approved these changes
Jan 29, 2021
random-zebra
added a commit
that referenced
this pull request
Feb 2, 2021
6948abd [BUG][GUI] Fix CWalletTx* casts to CTransaction* (random-zebra) Pull request description: Fix random GUI segfault during send. Since #2044 , we cannot cast `CWalletTx*` directly to `CTransaction*` (as `CMerkleTx` no longer inherits from `CTransaction`). We must use the `CTransactionRef` stored within it. ACKs for top commit: furszy: great catch 👌 , ACK 6948abd Fuzzbawls: utACK 6948abd Tree-SHA512: a9395d59bd64553a6e45592a66b6662a393098c560121e793121ada411643a77d349750a335c10ffc66ddafd54950fb1c6263583aa6218849a39aec1707ab6d9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of inheriting from
CTransaction, nowCWalletTxwill store it as member. Another step forward over the transaction complete immutability goal.An adaptation of c3f5673 with further needed changes, essentially: