Skip to content

[Sapling] Transparent inputs selection, fixing inverted order. #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
random-zebra merged 1 commit into from
Dec 10, 2020
Merged

[Sapling] Transparent inputs selection, fixing inverted order. #2046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sapling/sapling_operation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,9 +285,9 @@ OperationResult SaplingOperation::loadUtxos(TxValues& txValues)
return errorOut("Insufficient funds, no available UTXO to spend");
}

// sort in ascending order, so smaller utxos appear first
// sort in descending order, so higher utxos appear first
std::sort(transInputs.begin(), transInputs.end(), [](const COutput& i, const COutput& j) -> bool {
return i.Value() < j.Value();
return i.Value() > j.Value();
});

// Final step, append utxo to the transaction
Expand Down