Skip to content

[GUI][BugFix] Duplicate transaction records. #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
furszy merged 1 commit into from
Dec 23, 2020
Merged

[GUI][BugFix] Duplicate transaction records. #2096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/qt/transactionrecord.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ bool TransactionRecord::decomposeDebitTransaction(const CWallet* wallet, const C
}

// Decompose shielded debit
return decomposeShieldedDebitTransaction(wallet, wtx, nTxFee, involvesWatchAddress, parts);
return decomposeShieldedDebitTransaction(wallet, wtx, nTxFee, involvesWatchAddress, parts) || !parts.empty();
}

// Check whether all the shielded inputs and outputs are from and send to this wallet
Expand Down Expand Up @@ -445,10 +445,14 @@ QList<TransactionRecord> TransactionRecord::decomposeTransaction(const CWallet*
}
}

// if we get to this point, we have a mixed debit transaction, can't break down payees.
TransactionRecord record(wtx.GetHash(), wtx.GetTxTime(), wtx.GetTotalSize(), TransactionRecord::Other, "", nNet, 0);
record.involvesWatchAddress = involvesWatchAddress;
parts.append(record);
// Check if wasn't able to decompose the transaction
if (parts.empty()) {
Comment thread
random-zebra marked this conversation as resolved.
// if we get to this point, we have a mixed debit transaction, can't break down payees.
TransactionRecord record(wtx.GetHash(), wtx.GetTxTime(), wtx.GetTotalSize(), TransactionRecord::Other, "", nNet,
0);
record.involvesWatchAddress = involvesWatchAddress;
parts.append(record);
}
return parts;
}

Expand Down