[Refactor] Several updates to the base chain params structure#2164
Merged
Conversation
furszy
force-pushed
the
2020_chainparams_update
branch
from
74c3d2c to
6d28ded
Compare
furszy
changed the title
furszy
force-pushed
the
2020_chainparams_update
branch
from
6d28ded to
d3d7c9f
Compare
…stnet() direct call.
…ChainParams Adaptation of btc@c4973aaaf6655dd3e311b88727ec3f23ed0d0d2f
…ants Plus removed the, after changes, unused CBaseChainParams::Network. Adaptation coming from btc@f3525e24e3a156eaa004ca28a59fe2d449dc1f9e
… SelectBaseParamsFromCommandLine and SelectParamsFromCommandLin
furszy
force-pushed
the
2020_chainparams_update
branch
from
d3d7c9f to
d1244f3
Compare
Fuzzbawls
approved these changes
Feb 10, 2021
furszy
added a commit
that referenced
this pull request
Feb 12, 2021
4e1f270 Make CTransaction actually immutable (furszy) 896b5e2 Make DecodeHexTx return a CMutableTransaction (Pieter Wuille) b1e3a38 Switch GetTransaction to returning a CTransactionRef (furszy) Pull request description: Adaptation of bitcoin#8580, making the `CTransaction` object fully immutable. Fixing possible UB over the const members set that should only ever be assigned at construction time. first commit was cherry-picked from #2164, that one should get merged first. ACKs for top commit: random-zebra: Really nice. ACK 4e1f270. Fuzzbawls: ACK 4e1f270 Tree-SHA512: 4ade94d55aa1c3abb92a37bc4d5522fec308917e70656bf5c2f2af925b45e73a4928b799e40795546477295af350de4b15b29e0741825123af418cb566bf8331
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made several updates to the base chain params structure and further cleanups over the zerocoin code:
CBaseChainParams::Networkenum with string constants and unified better the network selection error + network help message (adaptation of test: a simpler way to disable mocktime inp2p_initial_headers_sync.pydashpay/dash#6235).zerocoin.h/cppandzpivchain.h/cpp.