[Misc] Init fixes + DisconnectBlock cleanup + zerocoin dead code removal.#2212
Merged
Conversation
While reading another PR I saw a mention of bitcoin#6358. The use case for SCHED_BATCH is to hint to the kernel that the thread is running a non-interactive workload that consumes a lot of CPU time. This is helpful on desktop machines where the loadblk thread can interfere with interactive applications. More details can be found in the sched(7) man page.
Adaptation of btc@cb1e319fe9e198c9c5cf5236fe9af5a3d748b9e8
Fuzzbawls
approved these changes
Feb 27, 2021
furszy
added a commit
that referenced
this pull request
Mar 13, 2021
…ead of 0 48b3bc4 util: Remove designator initializer from ScheduleBatchPriority (Wladimir J. van der Laan) 886b6ca util: Pass pthread_self() to pthread_setschedparam instead of 0 (Wladimir J. van der Laan) Pull request description: Coming straight from bitcoin#12923. Fixes a bug introduced in #2212 for **some** POSIX linux systems (observed on CentOS 7 currently) Original upstream text: > Nowhere in the man page of pthread_setschedparam it is mentioned that 0 is a valid value. The example uses pthread_self(), so should we. ACKs for top commit: furszy: utACK 48b3bc4 random-zebra: utACK 48b3bc4 Tree-SHA512: b7976efbe4659a20ca88e958dc419d6cf9a11867c0a1dc021af722f5878b4574a160680b35fecca348231c5477f52fd0a1e336f76968127acf0f5c018e2b6de7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grouped some small commits from init, validation and zc removal together to not end up pushing them separately.
fRequestShutdownmoved to std::atomic.init.cpp.