[wallet] Remove now unneeded stake P2PKH->P2PK output forced conversion#2299
Merged
Conversation
random-zebra
suggested changes
Apr 8, 2021
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
This is not taking into account regtest net.
v5 network upgrade is not active by default there.
If we remove the conversion to P2PK inputs, the block validity checks will fail before v5 NU enforcement.
We first need to relax the rules about the block signature (always accepting P2PKH coinstake outs), which is done inside #2295.
With that change, all the tests would be passing here.
So, imo either rebase this PR on top of #2295, or simply add these 3 commits there.
random-zebra
added
Block Generation
Author
|
Yeah, i did this one with my head on #2295. |
furszy
force-pushed
the
2021_wallet_cleanup
branch
from
7af40e5 to
12648c6
Compare
random-zebra
previously approved these changes
Apr 10, 2021
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
utACK 12648c6af92c0ce62d96a55b27e805783171debc
furszy
force-pushed
the
2021_wallet_cleanup
branch
from
12648c6 to
50ee79d
Compare
Author
|
Done, rebased on master. |
Fuzzbawls
approved these changes
May 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v5 activation, #1700 is active and there is no need to continue checking for the v5 NU enforcement during the coinstake generation in the mining process. This PR removes the extra validations and script conversion inside the wallet.