Skip to content

[build] Allow export of environ symbols#2357

Merged
furszy merged 1 commit into
PIVX-Project:masterfrom
furszy:2021_backport_envron_skip
May 6, 2021
Merged

[build] Allow export of environ symbols#2357
furszy merged 1 commit into
PIVX-Project:masterfrom
furszy:2021_backport_envron_skip

Conversation

@furszy
Copy link
Copy Markdown

@furszy furszy commented May 1, 2021

This export was introduced in #2278 which added

//! Necessary on some platforms
extern char** environ;

Which is one of the causes of the current broken gitian build.

Coming from f6e4225

This export was introduced in bitcoin#17270 which added
```
//! Necessary on some platforms
extern char** environ;
```
Copy link
Copy Markdown

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 32473aa

Copy link
Copy Markdown
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 32473aa

@furszy furszy merged commit 6d62386 into PIVX-Project:master May 6, 2021
@furszy furszy deleted the 2021_backport_envron_skip branch November 29, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants