[net processing] Swap out signals for an interface class#2417
Merged
furszy merged 3 commits intoJul 1, 2021
Conversation
There are a few too many edge-cases here to make this a scripted diff. The following commits will move a few functions into PeerLogicValidation, where the local connman instance can be used. This change prepares for that usage. Adapted from btc@28f11e9406b185dc87144f1f29af0d93eb115b4e
Drop boost signals in favor of a stateful class. This will allow the message processing loop to actually move to net_processing in a future step. Adapted from btc@8ad663c1fa88d68843e45580deced56112343183
The copy in PeerLogicValidation can be used instead.
furszy
force-pushed
the
2021_net_processing_swap_out_signals
branch
from
085e1af to
21f05c1
Compare
Fuzzbawls
approved these changes
Jul 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another decouple from #2411. Coming from bitcoin#10756.