[Refactor] Decouple enforcement of cbase payment from block version#2434
Merged
furszy merged 2 commits intoJun 23, 2021
Conversation
New rules shouldn't be enforced with a new block version (e.g. IsCoinbaseValueValid), because there might be blocks with that version *before* the relative network enforcement. And in this case we don't need to, as the check is already contextual.
This commit will be backported to 5.2 branch to signal the new release. Before 6.0 there will be another block version bump in master.
random-zebra
added a commit
to random-zebra/PIVX
that referenced
this pull request
Jun 19, 2021
random-zebra
added a commit
that referenced
this pull request
Jun 20, 2021
…ent) 9e29e51 [Validation] Bump default block version to 10 (no enforcement) (random-zebra) Pull request description: Backports 84261bc (#2434) ACKs for top commit: furszy: utACK 9e29e51 Fuzzbawls: utACK 9e29e51 Tree-SHA512: 44b90abf9fe7f6513ca8f2ea24adbdf684f12c0ab9b57e6244519c068f7d8a76187b7a66376d4c49054ec73fcaeefba5db63aac70b26153e5fb47179f37edb5b
Fuzzbawls
approved these changes
Jun 22, 2021
furszy
approved these changes
Jun 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New rules shouldn't be enforced with a new block version (e.g. IsCoinbaseValueValid), because there might be blocks with that version before the relative network enforcement.
And in this case we don't need to, as the check is already contextual.
First commit removes the dependency on block version 10, and restores the default version to 9.
Second commit simply bumps back the default version to 10. This commit is meant to be backported to 5.2 in order to signal the new release.