Decouple peer-processing-logic from block-connection-logic + BIP61 removal.#2464

Merged

random-zebra merged 13 commits into

PIVX-Project:masterfrom

furszy:2021_remove_processBlock_state

Jul 25, 2021

Commits on Jul 21, 2021

p2p: Remove BIP61 reject messages
furszy
committed
net_processing: Remove duplicate, and wrong, peer misbehaving due an invalid arriving block.
furszy
committed
net_processing: Clean CheckBlockSpam code and add proper cs_main locks in State() call and mapBlockIndex access.
furszy
committed
validation: Proper validation state set for "out of order" check in CheckBlock.
furszy
committed
Refactor: get rid off the error prone CValidationState argument in ProcessNewBlock.
furszy
committed
Move block spam filter check to BlockChecked
furszy
committed
Remove now unneeded `fAccepted` flag from ProcessNewBlock.
furszy
committed
Document 'DisconnectOldProtocol' call rationale in block processing.
furszy
committed
Remove IsBlockHashInChain function. Only used inside IsTransactionInChain.
furszy
committed
Move-only: IsTransactionInChain functions moved inside zpivchain.cpp and made static as them are only used there.
furszy
committed
Refactor: Name GetDataMsg enum and replace ppszTypeName array for direct GetCommand call.
furszy
committed
Clean few compiler warnings in blockassembler, validation, rpcwallet and evo_deterministicmns_tests files.
furszy
committed

Commits on Jul 22, 2021

Net_processing: Minimize tier two messages search time and improve code.
furszy
committed