Skip to content

[GUI][BugFix] Masternodes screen, fix impossibility to start Masternodes #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
random-zebra merged 1 commit into from
Aug 25, 2021
Merged

[GUI][BugFix] Masternodes screen, fix impossibility to start Masternodes #2529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/qt/pivx/masternodeswidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ MasterNodesWidget::MasterNodesWidget(PIVXGUI *parent) :
new MNHolder(isLightTheme()),
this
);
mnModel = new MNModel(this, walletModel);

this->setStyleSheet(parent->styleSheet());

Expand Down Expand Up @@ -142,6 +141,7 @@ void MasterNodesWidget::hideEvent(QHideEvent *event)
void MasterNodesWidget::loadWalletModel()
{
if (walletModel) {
mnModel = new MNModel(this, walletModel);
ui->listMn->setModel(mnModel);
ui->listMn->setModelColumn(AddressTableModel::Label);
updateListState();
Expand Down Expand Up @@ -216,12 +216,12 @@ void MasterNodesWidget::onEditMNClicked()
}
}

void MasterNodesWidget::startAlias(QString strAlias)
void MasterNodesWidget::startAlias(const QString& strAlias)
{
QString strStatusHtml;
strStatusHtml += "Alias: " + strAlias + " ";

for (CMasternodeConfig::CMasternodeEntry mne : masternodeConfig.getEntries()) {
for (const auto& mne : masternodeConfig.getEntries()) {
if (mne.getAlias() == strAlias.toStdString()) {
std::string strError;
strStatusHtml += (!startMN(mne, strError)) ? ("failed to start.\nError: " + QString::fromStdString(strError)) : "successfully started.";
Expand All @@ -232,7 +232,7 @@ void MasterNodesWidget::startAlias(QString strAlias)
updateModelAndInform(strStatusHtml);
}

void MasterNodesWidget::updateModelAndInform(QString informText)
void MasterNodesWidget::updateModelAndInform(const QString& informText)
{
mnModel->updateMNList();
inform(informText);
Expand Down Expand Up @@ -276,7 +276,7 @@ bool MasterNodesWidget::startAll(QString& failText, bool onlyMissing)
{
int amountOfMnFailed = 0;
int amountOfMnStarted = 0;
for (CMasternodeConfig::CMasternodeEntry mne : masternodeConfig.getEntries()) {
for (const auto& mne : masternodeConfig.getEntries()) {
// Check for missing only
QString mnAlias = QString::fromStdString(mne.getAlias());
if (onlyMissing && !mnModel->isMNInactive(mnAlias)) {
Expand Down
4 changes: 2 additions & 2 deletions src/qt/pivx/masternodeswidget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ private Q_SLOTS:
void onDeleteMNClicked();
void onInfoMNClicked();
void updateListState();
void updateModelAndInform(QString informText);
void updateModelAndInform(const QString& informText);

private:
Ui::MasterNodesWidget *ui;
Expand All @@ -65,7 +65,7 @@ private Q_SLOTS:
std::atomic<bool> isLoading;

bool checkMNsNetwork();
void startAlias(QString strAlias);
void startAlias(const QString& strAlias);
bool startAll(QString& failedMN, bool onlyMissing);
bool startMN(const CMasternodeConfig::CMasternodeEntry& mne, std::string& strError);
};
Expand Down