[Backport] 5.3.3 backports#2613
Merged
Merged
Conversation
…sn't done. plus decrease the possible mn list sync request time to 1 hour instead of 3.
…m different peers in case of needing it. In the previous flow, if one of the requests failed for an already asked sync request (blocked period) or any other issue, the sync requests to the peers that come after it, in an ordered list, were never done.
Before, once the first budget sync message was received, the complete budget sync requests were blocked for the entire peer's life cycle. This modifies the behaviour to block it only for an hour after the budget sync request reception.
…roposals, request proposals' votes as well.
…and document masternode-sync process.
…st sync" DoS validation. And decrease DoS penalization to 20 for now (this will be totally erased on v6.0).
…sync process is completed.
…hen the item is received. The inv item is stored forever in the set.. which will grow infinitely with all the asked for INVs and block any possible subsequent request.
Performed after a chain + tier two data removal.
added 15 more proposals to have a higher network movement in the test.
…addr isCompat function.
…ode addr that causes a signature verification failure.
The mnb can easily be invalid, it's arriving from the network
Added the following changes: 1) Do not accept txs nor tier two INV messages during IBD (with only one exception). None of the received data can be validated without be synced with the chain. 2) Only accept sporks during IBD, they are always welcome.
…phase. It simply makes no sense to relay mnb, votes, proposals, etc. to the peers from where we are synchronizing our initial state while we are doing it.
As they are not totally connected to us, if we send any INV msg they will raise the DoS scoring.
We already have it, no need to continue requesting it to anyone else.
On the Welcome screen, when users change the language, a call to Qt's internal `retranslateUi()` is made. This, however does not take into consideration any arguments in a source string, and instead treats them as string literals (ie, `%1` is not considered an argument, but rather a literal string) Fix this by adding a supplemental call to `setText()` that DOES allow for argument processing directly after the retranslation.
Author
|
Added trivial #2617 as well. |
…chronization state. if it happens before or while the node's tier two initial synchronization is being executed, the peer will move to single items requests instead of requesting the full list. Plus, decrease the DoS score for a bad mnb signature during the initial synchronization process, so we don't end up banning pre v5.3.3 nodes too fast for an invalidly serialized mnb (this issue was solved in bitcoin#2611 removing the mnb BIP155 flag, this is only an extra guard to give a bit more time to non-updated peers to upgrade while the network is upgrading).
Author
|
I did not backport them on purpose, to not extend v5.3.3 more than what it should. Those are only small code cleanups, not related to v5.3.3 goal, that require other code cleanups dependencies (that could or not require other PRs). if you have a strong reason to include them, can check them once more and add them but if not, it would be simpler to move forward without them. |
Fuzzbawls
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #2611 for v5.3.3
So we do a release focused on solving tier two network synchronization and re-synchronization issues that are mainly affecting the superblock payments window and causing network forks.
Update:
Added #2617 and #2622 as well.